Stdlib: withhold ext/gmp on reference profile (#22860)#23000
Closed
PurHur wants to merge 1 commit into
Closed
Conversation
Match Zend without ext-gmp: extension_loaded('gmp') / function_exists('gmp_*') /
class_exists('GMP') stay false until PHP_COMPILER_PROFILE=8.4 enables the
pure-PHP surface (same phantom gate as snmp/zip).
Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Owner
Author
|
Closing as duplicate of #22998 (already on master: This branch reached the same gate independently; master won the merge race. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/gmpon the reference profile soextension_loaded('gmp'),function_exists('gmp_*'), andclass_exists('GMP')match Zend when host ext-gmp is absent (CompilerVersion::supportsGmp()/GmpExtensionPolicy, same phantom gate as snmp/zip).PHP_COMPILER_PROFILE=8.4.ext/gmp/gmp.c; PHP:ext/gmp/GmpExtensionPolicy.php+ Module/ModuleRegistry/BuiltinIntrospectionPolicy.Closes #22860
Test plan
php bin/vm.php test/repro/extension_loaded_gmp_phantom.php→loaded=no/gmp_add=no/class=noPHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/extension_loaded_gmp_phantom.php→ yes +sum=5php test/repro/extension_loaded_gmp_phantom.php→ no (matches reference VM)./script/phpunit.sh --filter 'extension_loaded_gmp|GmpModuleTest|add_cmp|gmp_binomial|…'→ OK (27 tests)php script/bootstrap-inventory.php --check→ OK 6519/6519bin/compile.phpsmoke blocked this run by stuckPackJitHelperhelper emit on the harness (shared Module gates; retry when helper cache is healthy)Trust probe (this run)
user_release_ready: no—north-star5-fastfail (gen-0 mismatch #8713/#22642)Made with Cursor